Remove broken tests temporarily (#987) #988
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 25, 2024
passy
force-pushed
the
pr988
branch
2 times, most recently
from
bfb5287
to
095385e
Compare
passy
force-pushed
the
pr988
branch
2 times, most recently
from
d06cb81
to
86d3d0f
Compare
passy
force-pushed
the
pr988
branch
2 times, most recently
from
30ba258
to
d403468
Compare
Closed
|
@passy has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary:
The tests are not actually being run.
After upgrading the Gradle plugin on GitHub, it has become clear that these are running without the AP processing them. When processed, they raise some fairly obvious mistakes:
{P1221730610}
This is removing them for now so we can get the update and new release out.
Done using
```
pastry P1221730610 | rg -F '/src/' | awk '{print $1}' | cut -d ':' -f 1 | uniq | sed -e 's:/Users/realpassy/Projects/java/litho/::' | xargs hg rm -v
```
To restore the rests, let's do it one-by-one by doing `hg revert -r 5ac836c8ff21bb798ce1aba47a47857f93f3d47c^ -- litho-it/path/to/test.java`
Differential Revision: D56517990
|
@passy has updated the pull request. You must reimport the pull request before landing. |
|
@passy has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The tests are not actually being run.
After upgrading the Gradle plugin on GitHub, it has become clear that these are running without the AP processing them. When processed, they raise some fairly obvious mistakes:
{P1221730610}
This is removing them for now so we can get the update and new release out.
Done using
To restore the rests, let's do it one-by-one by doing
hg revert -r 5ac836c8ff21bb798ce1aba47a47857f93f3d47c^ -- litho-it/path/to/test.javaDifferential Revision: D56517990
Stack created with Sapling. Best reviewed with ReviewStack.