Formatting, spinlock, and 32-bit iOS frameworks #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added confirming Done after new sections Print all architectures being built, not just first Don't print out options (e.g. SDK_VERSION) for platforms not being built Added reassuring "any \"No such file or directory\" messages are fine" when appropriate
Remove duplicated updateBoost
|
After I did this pull request, I saw there was one outstanding from @paynerc. His implementation was better, so I've ditched mine and merged his into the other changes I made. |
|
And after some more testing, realized that the exact same issue applies to Mac Catalyst: if you have both architectures, they need to be lipo'd together before putting into XCFramework. |
|
@mackworth Sorry - been focusing on other things recently. Regarding your previous comment, does that mean there needs to be a change to this PR, or is it still ready to go? |
|
Yes, I've made those changes. I believe we're good to go, although I'd love @paynerc to review. |
|
just a bump to see if @paynerc approves and if @faithfracture should proceed. |
According to boost.org: https://www.boost.org/users/news/boost_has_moved_downloads_to_jfr.html
kambala-decapitator
added a commit
to kambala-decapitator/Apple-Boost-BuildScript
that referenced
this pull request
Nov 28, 2021
kambala-decapitator
added a commit
to kambala-decapitator/Apple-Boost-BuildScript
that referenced
this pull request
May 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out iOS has the same issue as macOS, if you are generating 32-bit versions (i.e. supporting prior to 11.0). armv7 and arm64 need to be lipo'd together (as do the simulator versions). Otherwise, you get a similar error message when trying to build the framework.
In addition, this PR includes:
I included an update to the changelog (embarrassingly called "changeling" in commit msg) that reflect these changes and last PR.
If you want me to separate these commits or make any other changes, happy to do so.