Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update types.ts #8

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update types.ts #8

wants to merge 1 commit into from

Conversation

podlesny-j
Copy link

typescript check in our repo throws error:

node_modules/cypress-plugin-xhr-toggle/dist/types.d.ts(37,13): error TS2717: Subsequent property declarations must have the same type.  Property 'env' must be of type 'Partial<PluginEnvOptions> | undefined', but here has type 'PluginEnvOptions | undefined'.

I believe this might fix it...?

typescript check in our repo throws error:
```
node_modules/cypress-plugin-xhr-toggle/dist/types.d.ts(37,13): error TS2717: Subsequent property declarations must have the same type.  Property 'env' must be of type 'Partial<PluginEnvOptions> | undefined', but here has type 'PluginEnvOptions | undefined'.
```

I believe this should fix it...?
@podlesny-j
Copy link
Author

podlesny-j commented Apr 5, 2023

But to be honest I'm still pretty lost in TS.
But if you'll find time to take a look at this I'll gladly help if I can...

I have a feeling this could also be a cool content for one of your streaming sessions...? 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant