-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fleet UI: Accessibility button actions, tabbing #22916
base: main
Are you sure you want to change the base?
Conversation
@@ -53,7 +54,7 @@ class Button extends React.Component<IButtonProps, IButtonState> { | |||
static defaultProps = { | |||
size: "", | |||
type: "button", | |||
variant: "default", | |||
variant: "brand", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
default isn't even a variant. Brand has all the pseudo class styling on it.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #22916 +/- ##
==========================================
- Coverage 65.28% 65.27% -0.01%
==========================================
Files 1533 1533
Lines 119109 119118 +9
Branches 3640 3592 -48
==========================================
+ Hits 77755 77756 +1
- Misses 34148 34157 +9
+ Partials 7206 7205 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ecc8075
to
5755222
Compare
5755222
to
0ac0f3a
Compare
Issue
Part 3 of #22606
Description
TODO: released bug found: When a cancel button is highlighted, pressing enter should cancel not submit the form/modal
Screenrecording
TODO
Checklist for submitter
If some of the following don't apply, delete the relevant line.