Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fleet UI: Accessibility button actions, tabbing #22916

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

RachelElysia
Copy link
Member

@RachelElysia RachelElysia commented Oct 14, 2024

Issue

Part 3 of #22606

Description

  • Pressing enter when the upload/choose file button is selected will open the file uploader
  • Can now tab past the label dropdown on the host page
  • Small icon buttons now have styling when tabbing through the app (e.g. filter pill close button on host details page)

TODO: released bug found: When a cancel button is highlighted, pressing enter should cancel not submit the form/modal

Screenrecording

TODO

Checklist for submitter

If some of the following don't apply, delete the relevant line.

  • Manual QA for all new/changed functionality

@@ -53,7 +54,7 @@ class Button extends React.Component<IButtonProps, IButtonState> {
static defaultProps = {
size: "",
type: "button",
variant: "default",
variant: "brand",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

default isn't even a variant. Brand has all the pseudo class styling on it.

Copy link

codecov bot commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 10.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 65.27%. Comparing base (9dbe04d) to head (5755222).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
frontend/components/FileUploader/FileUploader.tsx 0.00% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #22916      +/-   ##
==========================================
- Coverage   65.28%   65.27%   -0.01%     
==========================================
  Files        1533     1533              
  Lines      119109   119118       +9     
  Branches     3640     3592      -48     
==========================================
+ Hits        77755    77756       +1     
- Misses      34148    34157       +9     
+ Partials     7206     7205       -1     
Flag Coverage Δ
frontend 52.02% <10.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RachelElysia RachelElysia changed the title Fleet UI: Fleet UI: Accessibility button actions, tabbing Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant