-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cria pré-definições de tipografia #19
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielguilhoto
commented
Aug 18, 2023
DSA_FONT_WEIGHT_NORMAL, | ||
DSA_LETTER_SPACING_NORMAL, | ||
DSA_LETTER_SPACING_WIDE, | ||
DSA_LINE_HEIGHT_L, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Usei os nomes de tokens novos, que ainda não estão no codebase, então os erros de lint são esperados. Mas vou fazer o merge só depois dos nomes novos entrarem na master.
leocpadua7
approved these changes
Aug 21, 2023
gabrielguilhoto
force-pushed
the
predefs-tokens
branch
from
August 21, 2023 21:02
50e0ca9
to
113df00
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contexto
Tínhamos criado os tokens de tipografia isolados (font family, font size, font weight etc.), mas queremos também uma forma de aplicar esses tokens em conjuntos como definidos no Figma. Mais detalhes em https://geekie.atlassian.net/browse/EOF-66.
Mudanças
Defini objetos com as pré-definições de tipografia, me baseando no que está documentado no Figma. Mais detalhes sobre a escolha desse formato no Notion.
Separei as pré-definições em 3 arquivos (
basic
,ludic
ereading
) de acordo com o tipo de fonte, agrupados numa pastapresets
, e documentei como usar no readme.Ainda está pendente:
Como testar
No SGLearner:
package.json
e rodandoyarn
ProfileEditor
) e usei ela na definição de um estilo