Loop through the frames with up and down keys #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The modified code allows the user to loop through the frames of an animation using the up and down keys, ensuring that they don't get stuck at the start or end of the animation. This behavior is often desirable in animation or slideshow applications, as it provides a more seamless user experience. The code checks if the user is at the beginning or end of the animation and loops back to the other end when they try to go beyond those limits. I had previously suggested that change on the original Piskel GitHub repository. However, I later discovered that the project had been completely abandoned. After reading your blog post and reviewing the changes you made to the source code, it appears that you are well-suited to continue a promising fork of the original project :)
|
I seem to have missed this! Sorry. Changes coming soon so will merge this in ASAP. |
|
Changed the base branch to |
|
Hi. Unfortunately, I'm on vacations. I tried to do that from the GitHub website on my phone, but I honestly have no idea what to do. So you'll have better time modifying the code yourself. It's only a few lines 😉 |
ayushmanchhabra
force-pushed
the
dev-1047
branch
3 times, most recently
from
c8d06b8
to
e384917
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The modified code allows the user to loop through the frames of an animation using the up and down keys, ensuring that they don't get stuck at the start or end of the animation.
This behavior is often desirable in animation or slideshow applications, as it provides a more seamless user experience.
The code checks if the user is at the beginning or end of the animation and loops back to the other end when they try to go beyond those limits.
I had previously suggested that change on the original Piskel GitHub repository. However, I later discovered that the project had been completely abandoned. After reading your blog post and reviewing the changes you made to the source code, it appears that you are well-suited to continue a promising fork of the original project :)