Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pointer][transmute] Migrate from util #1911

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

joshlf
Copy link
Member

@joshlf joshlf commented Oct 15, 2024

This prepares us to rename TransparentWrapper to TransmuteFrom,
which we'll do in a follow-up commit to preserve nice git diffs.

Makes progress on #1122


This PR is on branch ptr-overhaul.

@codecov-commenter
Copy link

codecov-commenter commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 32.95455% with 59 lines in your changes missing coverage. Please review.

Project coverage is 89.46%. Comparing base (706dccf) to head (4bd33fb).

Files with missing lines Patch % Lines
src/pointer/transmute.rs 39.18% 45 Missing ⚠️
src/util/macros.rs 0.00% 14 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1911   +/-   ##
=======================================
  Coverage   89.46%   89.46%           
=======================================
  Files          16       17    +1     
  Lines        5838     5838           
=======================================
  Hits         5223     5223           
  Misses        615      615           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joshlf joshlf force-pushed the Ifc49755af0d90eeefe7822d755d508403c266bda branch 3 times, most recently from c3a2206 to 7643459 Compare October 17, 2024 01:31
@joshlf joshlf changed the base branch from main to I3a111bf5647fdcc9805cbadf36f729ac69b28509 October 17, 2024 01:32
Base automatically changed from I3a111bf5647fdcc9805cbadf36f729ac69b28509 to main October 17, 2024 02:42
@joshlf joshlf changed the base branch from main to I3a111bf5647fdcc9805cbadf36f729ac69b28509 October 17, 2024 03:22
Base automatically changed from I3a111bf5647fdcc9805cbadf36f729ac69b28509 to main October 17, 2024 15:14
@joshlf joshlf force-pushed the Ifc49755af0d90eeefe7822d755d508403c266bda branch from 7643459 to b36cb1c Compare October 17, 2024 18:46
This prepares us to rename `TransparentWrapper` to `TransmuteFrom`,
which we'll do in a follow-up commit to preserve nice git diffs.

Makes progress on #1122

gherrit-pr-id: Ifc49755af0d90eeefe7822d755d508403c266bda
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants