cli: fix error fetching more bots #2925
Open
+49
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Iru89
changed the title
asastre
reviewed
Oct 10, 2024
Iru89
force-pushed
the
cli-fix-error-fetching-more-bots
branch
from
ac42103
to
50e2d7a
Compare
Test Results30 tests 30 ✅ 4m 29s ⏱️ Results for commit 6124b37. ♻️ This comment has been updated with latest results. |
vanbasten17
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add await when call getMoreBots
Remove duplicated call to getBots inside deployBotFromFlag function
Add generic type T to apiGet function