Fixes for Modular Converter on Windows #34266
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes some issues with Modular Converter on Windows.
rf"(src{os.sep}transformers{os.sep}.*|examples{os.sep}.*)"
results in(src\transformers\.*|examples\.*)
, due to\t
and\.
this regex fails, we use\\
here instead.This file was automatically generated from src\transformers\models\florence2\modular_florence2.py.
This could potentially cause issues elsewhere, and it's better to be standardized, so whenos.sep
==\
we replaceos.sep
with/
.open
encoding. On Windows the default encoding iscp1252
which doesn't work with🚨
, so we useencoding=utf-8
instead for allopen
. This particular fix is in effect in many other places in the codebase.Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@ArthurZucker