Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timing Adjustable - Level A guideline #49

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kristijan-mitrov
Copy link
Collaborator

I added an example for the 2.2.1 Timing Adjustable Level A guideline.
The 2.2.2 Pause, Stop, Hide Level A guideline was already well defined.

    Timing Adjustable
    Level A guideline
@kristijan-mitrov kristijan-mitrov added the enhancement New feature or request label Oct 16, 2024
@kristijan-mitrov kristijan-mitrov self-assigned this Oct 16, 2024
@kristijan-mitrov kristijan-mitrov linked an issue Oct 16, 2024 that may be closed by this pull request
2 tasks
Copy link
Member

@Aksi0m Aksi0m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I have only few comments.

@@ -78,16 +78,35 @@ When the user is navigating through the app **using the arrow keys on the keyboa

Provide users enough time to read and use the content.

### Timing Adjustable
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add the title like on iOS

### Timing Adjustable

Ensure that users can adjust the timing of content that is displayed on the screen.

*This guideline covers point 2.2.1 Timing Adjustable - Level A of the WCAG standard.*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I find this redundant. I know that I already commented this and that iOS has this too. But the updated title would already have this information.

Comment on lines +99 to +108
val SNACK_BAR_DURATION = 10_000
// Snackbar with custom duration
Snackbar.make(
view = view,
resId = R.string.action_completed,
startIconResId = Snackbar.LENGTH_LONG,
duration = SNACK_BAR_DURATION // Set custom duration
).show()
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What would be the compose alternative here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Android guidelines - Support user experience based on timing
2 participants