-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timing Adjustable - Level A guideline #49
base: master
Are you sure you want to change the base?
Timing Adjustable - Level A guideline #49
Conversation
Timing Adjustable Level A guideline
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I have only few comments.
@@ -78,16 +78,35 @@ When the user is navigating through the app **using the arrow keys on the keyboa | |||
|
|||
Provide users enough time to read and use the content. | |||
|
|||
### Timing Adjustable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add the title like on iOS
### Timing Adjustable | ||
|
||
Ensure that users can adjust the timing of content that is displayed on the screen. | ||
|
||
*This guideline covers point 2.2.1 Timing Adjustable - Level A of the WCAG standard.* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I find this redundant. I know that I already commented this and that iOS has this too. But the updated title would already have this information.
val SNACK_BAR_DURATION = 10_000 | ||
// Snackbar with custom duration | ||
Snackbar.make( | ||
view = view, | ||
resId = R.string.action_completed, | ||
startIconResId = Snackbar.LENGTH_LONG, | ||
duration = SNACK_BAR_DURATION // Set custom duration | ||
).show() | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What would be the compose alternative here?
I added an example for the 2.2.1 Timing Adjustable Level A guideline.
The 2.2.2 Pause, Stop, Hide Level A guideline was already well defined.