Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include_for_logged_out_users should still work when user excluded #293

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pedantic-git
Copy link

Hi Intercom devs! Please let me know what you think of this slight change in functionality.

The current behaviour when you have both include_for_logged_out_users and user.exclude_if set is a little counter-intuitive. The Intercom dialog appears when you're logged out, and when you're logged in as a valid user, but if you're logged in as an excluded user it disappears.

I'm not sure if there's a use case for this default behaviour, but it seems to make more sense to me to continue showing the include_for_logged_out_users Intercom dialog for excluded users, if that option is enabled.

This PR changes that - actually by removing a line from IntercomRails::ScriptTag. Excluded users still get no Intercom dialog at all if include_for_logged_out_users is false and I've made sure both cases are covered in the tests.

If I've missed your use case, I can make this a separate config option... let me know what works best for you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants