Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

count_by() and count_all() ignore the soft-delete status #84

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

carlos-mora
Copy link

Added the condition to adapt both method to be coherent with their counterparts get_many_by() and get_all().
I'm not sure if the count_all solution is the best, because it could be affected by previous where calls, but it is my best approach.

count_by and count_all() didn't take into account the soft-delete status in record counting. 
get_many_by() and get_all() does, so it looks better to follow the behavoir in the analogous method.
Not sure about this, ar's count_all operates independently of ar's status, the only way i found is to count_all_results().
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant