Agent should failed on SocketNotFoundException #280 #281
Conversation
If there are no matching candidate because a configuration mistake then the agent should failed.
|
Hi, thanks for your contribution! |
|
Jenkins please test this |
|
Jenkins test this please |
|
@jitsi-jenkins I sign CLA now. |
|
Do you have receive the CLA? Or do you need other information to continue with this PR? |
|
Confirmed the CLA, thanks. I need to understand the change and make sure it doesn't break other cases, and I haven't had the time to do it yet. I'll try to get to it this week. |
|
Any update on when this pull request will be merged? We ran into the same problem. |
|
Hi, can someone please review this PR? |
| @@ -944,6 +944,7 @@ protected void run() | |||
| "Pair failed: " | |||
| + pairToCheck.toShortString()); | |||
| pairToCheck.setStateFailed(); | |||
| updateCheckListAndTimerStates(pairToCheck); | |||
There was a problem hiding this comment.
This runs inside the synchronized (pairToCheck) block, which seems like a bad idea (I can't prove it would cause a deadlock but it worries me). Can you move it outside?
|
You are right. A listener should call ever outside of a synchronized. |
|
Jenkins test this please |
If there are no matching candidate because a configuration mistake then the agent should failed.