Push API for payload #285
Merged
Push API for payload #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
bgrozev
commented
Jul 18, 2024
bgrozev
commented
- feat: Add and use a generic Buffer class.
- fix: Improve isStunPacket check.
- wip: A new "push" API for the payload.
bgrozev
force-pushed
the
push-api
branch
2 times, most recently
from
2cd278f
to
750d9b3
Compare
| } | ||
| else | ||
| { | ||
| CandidatePair selectedPair = getSelectedPair(); |
There was a problem hiding this comment.
If you don't yet have a selected pair, but you do have validated pairs, it's valid to send over any validated pair. This will be needed for the project of reducing the startup time ICE/DTLS/etc takes. This doesn't needed to be part of this PR though, necessarily.
| localCandidate = l; | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Rather than searching all the local candidates every time we send a packet, would it make sense to save a lastLocalCandidate? Or are there locking issues or something?
JonathanLennox
previously approved these changes
Oct 1, 2024
Return early when the first two bits don't match. This is for: 1. Correctness: A packet that doesn't start with 00 is not STUN even if the magic cookie happens to match 2. Performance: Most packets are RTP and will fail the first byte check, so no need to check the magic cookie.
When enabled packets are passed directly to the application, squash: Fix setting initial addresses.
This should cause clients who've had NAT rebinding events to start failing their consent checks, so they reconnect.
JonathanLennox
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.