Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BG localization grammatical errors #1911

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

David-Mavrodiev
Copy link

Datepicker: Fix multiple grammar mistakes in BG localization file

There is a grammatical rule in Bulgarian language when word is shortened - the last letter must be always consonant.
However, for months and days there are official abbreviations, as follows:
Days -> "Нед.", "Пон.", "Втор.", "Ср.", "Четв.", "Пет.", "Съб."
Months -> "Ян.", "Февр.", "Мар", "Апр.", "Май", "Юни", "Юли", "Авг.", "Септ.", "Окт.", "Ноем.", "Дек."

Also year should have suffix "г." for example "2020 г."
"closeText", "prevText", "nextText", currentText must start with capital letter.

For reference

@jsf-clabot
Copy link

jsf-clabot commented Feb 15, 2020

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

@fnagel
Copy link
Member

fnagel commented Mar 23, 2020

Thanks for your contribution!

Before merging this PR we'll need some review of the localization file, see https://jqueryui.pbworks.com/w/page/139157592/Adding%20translations

Please fix the CGL issue and change commit message to something like "Datepicker: Fix Bulgarian localization grammatical errors"

@fnagel fnagel self-assigned this Mar 23, 2020
dayNamesShort: [ "Нед","Пон","Вто","Сря","Чет","Пет","Съб" ],
dayNamesMin: [ "Не","По","Вт","Ср","Че","Пе","Съ" ],
currentText: "Днес",
monthNames: [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree this is actually the nicer CGL style, but I would like to keep the code style as it was before. Reasons are: we want to keep consistency and it makes the review harder. Please change to one line per localization key.

Copy link
Member

@fnagel fnagel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the commit message to: "Datepicker: Fix grammatical errors in Bulgarian localization"

Base automatically changed from master to main February 19, 2021 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants