Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cfn): add plugin #584

Draft
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

georgettica
Copy link
Contributor

this is the initial work, we can start discussing from here #580

@georgettica
Copy link
Contributor Author

tests should not fail, I only added a new plugin, so maybe tests are flakey? something broken on master?

@kellyjonbrazil
Copy link
Owner

Nice - looks very clean! I was thinking along the same lines that we could add token types to the Ruamel YAML constructor.

Don't worry about the test failure - that's a behavior change in python 3.12 and 3.13 in the ipaddress library I need to address.

@georgettica
Copy link
Contributor Author

good to know on the test bit :)

what I will say that to make this actually functional I need to write a good portion of boilerplate, because now I just "ignored" these objects.

also where there are two predicates scalar and sequence and it doesn't choose the right one it breaks and I don't know how to fix.

I am not a Ruamel master so this is me and a GPT of your choice's doing.

@kellyjonbrazil
Copy link
Owner

@georgettica I'm starting to work on the next release. Do you think this is close to being ready or should we hold off with this parser? Thanks!

@georgettica
Copy link
Contributor Author

Let's hold off, just because I was waiting for another support / guidance.

I'll give it another push later at some point and let you know the status when I do

@kellyjonbrazil kellyjonbrazil changed the base branch from master to dev September 8, 2024 20:44
@kellyjonbrazil kellyjonbrazil marked this pull request as draft September 8, 2024 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants