move all work to main thread with serial executor #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndurell
commented
Oct 18, 2024
| @@ -1241,13 +1262,13 @@ extension TestStore where ScopedState: Equatable, Action: Equatable { | |||
| /// expected. | |||
| @MainActor | |||
| @_disfavoredOverload | |||
| func receive( | |||
| func receive( | |||
There was a problem hiding this comment.
Nit: for consistency, could we re-indent whole file with 4 spaces instead of 2? Select all (Command-A), then re-indent (Control-i)
There was a problem hiding this comment.
Yah I thought we had that set somewhere in the linting but maybe never enforced anything...
There was a problem hiding this comment.
That might make the diff hard to read.
ndurell
commented
Oct 18, 2024
| if uncheckedUseMainSerialExecutor { | ||
| await Task.yield() | ||
| } else { | ||
| await self.reducer.effectDidSubscribe.stream.first(where: { _ in true }) |
There was a problem hiding this comment.
This is different in TCA - might backport that change too..
ab1470
approved these changes
Oct 18, 2024
| @@ -1241,13 +1262,13 @@ extension TestStore where ScopedState: Equatable, Action: Equatable { | |||
| /// expected. | |||
| @MainActor | |||
| @_disfavoredOverload | |||
| func receive( | |||
| func receive( | |||
There was a problem hiding this comment.
Nit: for consistency, could we re-indent whole file with 4 spaces instead of 2? Select all (Command-A), then re-indent (Control-i)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This backports some stuff from the new test store from TCA.
This should move all store tests effects to the main thread.
Check List
Manual Test Plan
Supporting Materials