Support ray job #1123
Support ray job #1123
Conversation
|
@qile123 Thank you for this great contribution! Please rebase your PR. |
qile123
force-pushed
the
feature/ray-job
branch
from
9c7d63f
to
0c7d75a
Compare
qile123
force-pushed
the
feature/ray-job
branch
from
0c7d75a
to
46a081e
Compare
pkg/apis/types/training.go
Outdated
| // RayCluster defines the ray cluster | ||
| RayJob TrainingJobType = "rayjob" |
There was a problem hiding this comment.
| // RayCluster defines the ray cluster | |
| RayJob TrainingJobType = "rayjob" | |
| // RayJob defines the ray job | |
| RayJob TrainingJobType = "rayjob" |
|
@qile123 Are you willing to contribute some docs about how to submit an example Ray job? |
Certainly, I'm more than happy to contribute documentation on submitting a sample Ray job. |
qile123
force-pushed
the
feature/ray-job
branch
3 times, most recently
from
578fa03
to
f319e32
Compare
pkg/argsbuilder/submit_rayjob.go
Outdated
| @@ -0,0 +1,280 @@ | |||
| // Copyright 2018 The Kubeflow Authors | |||
There was a problem hiding this comment.
| // Copyright 2018 The Kubeflow Authors | |
| // Copyright 2024 The Kubeflow Authors. |
| allocatedGPU int64 | ||
| trainerType types.TrainingJobType // return trainer type: rayjob | ||
| } | ||
|
|
There was a problem hiding this comment.
| // RayJob implements the TrainingJob interface. | |
| var _ TrainingJob = &RayJob{} |
It would be better to add the above code to ensure that RayJob implements the TrainingJob interface.
| // check if it's enabled | ||
| enabled bool | ||
| } | ||
|
|
There was a problem hiding this comment.
| // RayJobTrainer implements the Trainer interface. | |
| var _ Trainer = &RayJobTrainer{} |
qile123
force-pushed
the
feature/ray-job
branch
from
f319e32
to
f486a8b
Compare
|
@qile123 Could you rebase this PR please? There are some merge conflicts due to the recent merged PRs. |
sure |
qile123
force-pushed
the
feature/ray-job
branch
from
f486a8b
to
021ca4e
Compare
Signed-off-by: taiku <[email protected]>
qile123
force-pushed
the
feature/ray-job
branch
from
021ca4e
to
21eb434
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ChenYi015 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This PR is used to support ray job in arena.
Which issue(s) this PR fixes (optional, in
Fixes #<issue number>, #<issue number>, ...format, will close the issue(s) when PR gets merged):Fixes #1120