This repository has been archived by the owner on Sep 1, 2021. It is now read-only.
use extension context for notebook search #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanrenmsft
reviewed
Sep 4, 2020
|
|
||
| // Each notebook or markdown file packaged with your extension will be found through this | ||
| // function so that they can be individually opened through the `showNotebookDocument` command. | ||
| const extractNotebooksFromFolder = (fullFolderPath: string, notebookNames: Array<string>) => { | ||
| const extractNotebooksFromFolder = (fullFolderPath: string) => { |
There was a problem hiding this comment.
please add a return type to the method signature :string[]
alanrenmsft
reviewed
Sep 4, 2020
| @@ -65,7 +35,7 @@ const getFolderContent = (folderPath: string) => { | |||
| // to occur when you launch the book, add to the activate function. | |||
| export function activate(context: vscode.ExtensionContext) { | |||
| context.subscriptions.push(vscode.commands.registerCommand('launchNotebooks.<%= name %>', () => { | |||
| let notebooksToDisplay: Array<string> = processNotebooks(); | |||
| let notebooksToDisplay: Array<string> = extractNotebooksFromFolder(context.extensionPath); | |||
| notebooksToDisplay.forEach(name => { | |||
There was a problem hiding this comment.
upon extension activation, this will open all the notebooks? sounds scary 😨
alanrenmsft
reviewed
Sep 4, 2020
|
|
||
| // Each notebook or markdown file packaged with your extension will be found through this | ||
| // function so that they can be individually opened through the `showNotebookDocument` command. | ||
| const extractNotebooksFromFolder = (fullFolderPath: string, notebookNames: Array<string>) => { | ||
| const extractNotebooksFromFolder = (fullFolderPath: string) => { | ||
| let notebookNames: Array<string> = []; | ||
| const files = getFolderContent(fullFolderPath); |
There was a problem hiding this comment.
if i read this correctly, you only handle the files in the top level folder without recursively going to the sub folders, by design?
alanrenmsft
approved these changes
Sep 4, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #37 - updates what the notebook and Jupyter book extensions using extension.contextPath to find files.