Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add no color option #114

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

adamdmharvey
Copy link

Fixes #36. This is an attempt to add the command line parameter to support no color mode.

  • Added -z / --no-color.
  • Re-aligned the command line options code to make it easier to edit.
  • Disabled color via _chalk, and added square brackets around spelling mistakes, such as: [[[mistaeks]]].
  • Updated README.md

Two outstanding questions for feedback:

  1. Couldn't decide on the best single letter for the parameter, so I went with -z. -c seemed more like it would ENABLE color, not disable it. Happy for feedback to adjust it. Could possibly simply use --no-color and no single letter if preferred?
  2. I thought the triple square brackets worked, but open to other's opinions?

I couldn't find any CONTRIBUTING guidelines, so I am simply submitting straight into master. Hope that's ok!

Added the color option, and also reorganized the command line parameters to make them easier to review in code.
To align to British spelling, per the pipeline tests.
@adamdmharvey
Copy link
Author

Changed the parameter to --no-colour and updated the docs/code as appropriate, so it would pass the pipeline spell check. :)

@adamdmharvey
Copy link
Author

I also notice on the README you said the next major version may switch to US English? If so, I can a) put color back, and b) update the pipeline to force english spell checking, which should allow it to pass the CI.

@RyanCopley
Copy link

@lukeapage Could this please be merged? It would be very helpful

@dduportal
Copy link

Hello and thanks for all of this work!

As an end user, I'm giving a 👍 to this feature. Not only this spellchecker is NEAT, but also this feature !

@magnoliaceiling
Copy link

This merge would be so incredibly helpful, I don't suppose it could be merged in @robatwilliams or @lukeapage?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support no color
4 participants