Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connect actual and expects types in equal() and is() #239

Merged
merged 5 commits into from
Sep 6, 2023

Conversation

ai
Copy link
Contributor

@ai ai commented Sep 6, 2023

This changes will improve TypeScript support:

  1. User will have autocomplete in tests:

Captura desde 2023-09-06 15-12-54

  1. Refactoring will be a little easier since test will help you guide what types you need to update (refactoring will be a little faster).

Captura desde 2023-09-06 15-13-18

Copy link
Owner

@lukeed lukeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :) Can you leave these as inline function declarations tho

@ai
Copy link
Contributor Author

ai commented Sep 6, 2023

Can you leave these as inline function declarations tho

Sure. It will not cover all cases, but we could start from simpler version.

@lukeed
Copy link
Owner

lukeed commented Sep 6, 2023

Why won’t it cover? You can still overload the function definitions. I just didn’t want to add a new interface

@ai
Copy link
Contributor Author

ai commented Sep 6, 2023

You can still overload the function definitions. I just didn’t want to add a new interface

Got it! Pushed.

@codecov-commenter
Copy link

Codecov Report

Patch and project coverage have no change.

Comparison is base (56e1cb2) 89.13% compared to head (cd1efce) 89.13%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #239   +/-   ##
=======================================
  Coverage   89.13%   89.13%           
=======================================
  Files           3        3           
  Lines         313      313           
=======================================
  Hits          279      279           
  Misses         34       34           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lukeed lukeed merged commit 0d5dd60 into lukeed:master Sep 6, 2023
15 checks passed
@JaKXz
Copy link

JaKXz commented Dec 2, 2023

This is a cool change :) just curious, is a release planned to include this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants