Support getting the last polygon coordinate

mapbox · Jul 24, 2020 · b20767d · b20767d
1 parent b63c0a4
commit b20767d
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 2 deletions.
diff --git a/src/feature_types/polygon.js b/src/feature_types/polygon.js
@@ -47,12 +47,16 @@ Polygon.prototype.removeCoordinate = function(path) {
 
 Polygon.prototype.getCoordinate = function(path) {
   const ids = path.split('.').map(x => parseInt(x, 10));
-  const ring = this.coordinates[ids[0]];
+  const coords = this.coordinates[ids[0]];
+  const ring = coords.concat([coords[0]]);
   return JSON.parse(JSON.stringify(ring[ids[1]]));
 };
 
 Polygon.prototype.getCoordinates = function() {
-  return this.coordinates.map(coords => coords.concat([coords[0]]));
+  return this.coordinates.map((coords) => {
+    const ring = coords.concat([coords[0]]);
+    return ring;
+  });
 };
 
 Polygon.prototype.updateCoordinate = function(path, lng, lat) {

diff --git a/test/polygon.test.js b/test/polygon.test.js
@@ -53,6 +53,17 @@ test('Polygon#isValid', (t) => {
   t.end();
 });
 
+test('Polygon#getCoordinate', (t) => {
+  const rawPolygon = createFeature('polygon');
+  rawPolygon.geometry.coordinates = [[[1, 2], [3, 4], [5, 6], [1, 2]]];
+  const polygon = new Polygon(createMockCtx(), rawPolygon);
+
+  t.deepEqual(polygon.getCoordinate('0.0'), [1, 2], 'getCoordinate returns the first coordinate');
+  t.deepEqual(polygon.getCoordinate('0.3'), [1, 2], 'getCoordinate returns the first coordinate as the last coordinate');
+
+  t.end();
+});
+
 test('Polygon#incomingCoords, Polygon#getCoordinates', (t) => {
   const rawPolygon = createFeature('polygon');
   const polygon = new Polygon(createMockCtx(), rawPolygon);