Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Dockerfile instructions and eliminate duplication of success message #1334

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Refactor Dockerfile instructions and eliminate duplication of success message #1334

wants to merge 1 commit into from
+20 −14

Conversation

rylin07
Copy link

@rylin07 rylin07 commented Oct 21, 2024 •
edited
Loading

This is based on some SonarQube suggestions that does not have the biggest changes, but it helps with enhancing maintainability.

Changes:

  • Updated Dockerfile instructions to be uppercase for improved readability and adherence to coding standards.
  • Refactored institutions_controller, merchants_controller, and transactions_controller by defining a SUCCESS constant to avoid duplicating the .success string multiple times, enhancing maintainability.

Thanks to @bigboimo for help test.

@rylin07
Refactor Dockerfile to use uppercase for instructions to enhance read…
93c7d52 
…ability and follow coding conventions. Also, define a SUCCESS_MESSAGE constant in InstitutionsController to avoid duplication of '.success' and improve maintainability.
@rylin07
Copy link
Author

rylin07 commented Oct 21, 2024

Thanks to @Anish-Chanda for introducing SonarQube.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iwfyou iwfyou iwfyou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rylin07 @iwfyou