Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repository Management #3927

Draft
wants to merge 17 commits into
base: main
Choose a base branch
from
Draft

Repository Management #3927

wants to merge 17 commits into from

Conversation

dhoehna
Copy link
Contributor

@dhoehna dhoehna commented Oct 4, 2024

Summary of the pull request

The main contribution is database migration and the tests for database migration.

The second contribution is removing the repository section from File Explorer Customization.

Smaller changes

  1. Implemented some edge cases for repository actions.
    1. Moving repositories across drives.
  2. Added a progress ring when moving repositories.
  3. Deleting a repository is now behind the scenes.
  4. Moved Repository Management out of experimental.
  5. Moved Repository Management to be under "Machine Configuration" in the nav menu.
  6. Removing the old repository location after moving.

References and relevant issues

I will make another PR with documentation on everything, including how to migrate the database.

Detailed description of the pull request / Additional comments

Validation steps performed

Movies and tests.

PR checklist

  • Closes #xxx
  • Tests added/passed
  • Documentation updated

Movies!
Database migration in action!
DatabaseMigration

Cloning Repositories into Repository Manager!
CloningRepositoriesIntoRepositoryManager

Adding an existing repository!
AddingAnExistingRepository

Repository actions except Move, Hide, and Delete!
https://github.com/user-attachments/assets/dad1899f-2c05-4881-9648-261f97a6ca77

Move, Hide, and Delete!
https://github.com/user-attachments/assets/1f8aae5e-b1bf-490c-9bbb-e0326f8c9eac

@@ -13,7 +13,6 @@
<StackPanel MaxWidth="{ThemeResource MaxPageContentWidth}" Margin="{ThemeResource ContentPageMargin}">
<views:FileExplorerView />
<views:VersionControlIntegrationSettingsView Visibility="{x:Bind ViewModel.IsFeatureEnabled}"/>
<views:AddRepositoriesView Visibility="{x:Bind ViewModel.IsFeatureEnabled}"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The AddRepositoriesView may need to be present for a while inside Dev Home and cannot be removed. Starting an offline email thread for further discussion. Thanks!

Copy link
Collaborator

@krschau krschau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Holding check-ins for the moment.

@dhoehna dhoehna marked this pull request as draft October 9, 2024 17:19
@dhoehna
Copy link
Contributor Author

dhoehna commented Oct 9, 2024

Moving into draft because the team wants to withhold any feature PR's until a later date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants