Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Playwright.csproj to upgrade Microsoft.Bcl.AsyncInterfaces #3010

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

RaminJolfaei
Copy link

@RaminJolfaei RaminJolfaei commented Sep 27, 2024

upgrade Microsoft.Bcl.AsyncInterfaces to latest version 8.0.0

@RaminJolfaei RaminJolfaei changed the title Update Playwright.csproj to upgrade Microsoft.Bcl.AsyncInterfaces to … Update Playwright.csproj to upgrade Microsoft.Bcl.AsyncInterfaces Sep 27, 2024
@campersau
Copy link
Contributor

Is there a specific reason for this?
In my opinion libraries should use the lowest version possible since the users can override them by explicitly include the references themselves. This was also done with System.Text.Json here #2720
Also since System.Text.Json references Microsoft.Bcl.AsyncInterfaces as well, these should be kept in sync.

@Meir017
Copy link
Contributor

Meir017 commented Sep 27, 2024

I think as long as our dependencies support netstandard we should be ok updating, see https://www.nuget.org/packages/Microsoft.Bcl.AsyncInterfaces/8.0.0#supportedframeworks-body-tab
image

@RaminJolfaei
Copy link
Author

RaminJolfaei commented Sep 28, 2024

My primary reason for upgrading Microsoft.Bcl.AsyncInterfaces to version 8.0.0 is that our DevOps pipeline throws an error during the post-compile step. The pipeline checks DLL references and fails when it doesn’t find version 6 in the bin folder. To resolve this issue and ensure the pipeline can complete successfully, the upgrade to version 8 is necessary. I believe this change will not have any adverse side effects in other environments.

Additionally, most of the other packages we use are now dependent on version 8.0.0 of Microsoft.Bcl.AsyncInterfaces, making this upgrade essential for maintaining compatibility across the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants