Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parameters in new ChatMessageContent are not ordered properly #102

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ebCrypto
Copy link

Motivation and Context

  1. Why is this change required?
    Chat Message Content are incorrect
  2. What problem does it solve?
    The modelId incorrectly gets added to the ChatMessageContent.Content

Description

The constructor ChatMessageContent in Microsoft.SemanticKernel.Abstractions expects parameters like so:

 [JsonConstructor]
 public ChatMessageContent(
     AuthorRole role,
     string? content,
     string? modelId = null,
     object? innerContent = null,
     Encoding? encoding = null,
     IReadOnlyDictionary<string, object?>? metadata = null)
     : base(innerContent, modelId, metadata)

Content is expected BEFORE ModelId.

Contribution Checklist

@ebCrypto ebCrypto changed the title parameters in new ChatMessageContent a not ordered properly parameters in new ChatMessageContent are not ordered properly Oct 11, 2024
@ebCrypto
Copy link
Author

@microsoft-github-policy-service agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant