Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check with new paradox #346

Merged
merged 10 commits into from
Feb 28, 2024
Merged

check with new paradox #346

merged 10 commits into from
Feb 28, 2024

Conversation

mb706
Copy link
Collaborator

@mb706 mb706 commented Jan 14, 2024

No description provided.

@mb706 mb706 mentioned this pull request Jan 14, 2024
@bblodfon
Copy link
Collaborator

@mb706 let me know if this is ready for review

@mb706 mb706 marked this pull request as ready for review February 28, 2024 16:14
@mb706
Copy link
Collaborator Author

mb706 commented Feb 28, 2024

@bblodfon this can be merged now.

For more explanation, this PR prepares for the upcoming paradox release, which can already be seen on github: mlr-org/paradox. The new version will throw an error when a parameter has a 'default' value and also has the 'required' tag. This is because the semantics of the 'default' value is "what does this parameter behave like when it is not set" -- this is in contradiction with the "required" tag, which indicates that a parameter must always be set.

There is another minor change that was necessary because of the way PipeOps with compound ParamSets work once paradox is updated. All changes are done in a way that they are compatible both with old as well as new versions of paradox / mlr3pipelines.

Besides that, I have also adapted the "dev" checks to check against the github version of paradox. This is because paradox on github will not be uploaded to CRAN for a few more weeks (until all the other changes are on CRAN and other package maintainers had their time to follow suit). Until then, it is best to check both against CRAN as well as github versions of various packages.

@bblodfon bblodfon merged commit 7d02a80 into main Feb 28, 2024
5 checks passed
@bblodfon bblodfon deleted the s3params_compat branch February 28, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants