Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor styling of checkboxes #224

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SergioCrisostomo
Copy link
Member

FF is hard to style when it comes to checkboxes. With this change we
have a label and a span doing the style job and the checkbox just
storing the state.

FF is hard to style when it comes to checkboxes. With this change we
have a label and a span doing the style job and the checkbox just
storing the state.
@@ -18,10 +18,12 @@ block main

label
input(type="checkbox", name="minified", value="1")
span
| Download minified source code
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the text be inside the <span>?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arian no, the span is just a "holder" for the square showing the "selected"/"not selected" state. So the idea is having the span replacing the checkbox itself that was hard to style and is now display: none;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants