Skip to content

Commit

Permalink
chore: drop quibble dependency
Browse files Browse the repository at this point in the history
  • Loading branch information
mshima committed Oct 15, 2024
1 parent ba03ede commit 70e04d3
Show file tree
Hide file tree
Showing 4 changed files with 24 additions and 42 deletions.
5 changes: 2 additions & 3 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

29 changes: 15 additions & 14 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -80,13 +80,14 @@
"which-package-manager": "^0.0.1"
},
"devDependencies": {
"@yeoman/eslint": "0.2.0",
"@types/debug": "^4.1.9",
"@types/lodash-es": "^4.17.9",
"@types/semver": "^7.5.3",
"@yeoman/eslint": "0.2.0",
"c8": "^10.1.2",
"cpy-cli": "^5.0.0",
"esmocha": "^2.0.0",
"eslint": "9.12.0",
"esmocha": "github:mshima/esmocha#mocks",
"fs-extra": "^11.1.1",
"jsdoc": "^4.0.2",
"prettier": "3.0.3",
Expand All @@ -97,7 +98,6 @@
"sinon-test": "^3.1.5",
"strip-ansi": "^7.1.0",
"typescript": "5.2.2",
"eslint": "9.12.0",
"yeoman-assert": "^3.1.1",
"yeoman-environment": "file:./",
"yeoman-generator-2": "npm:yeoman-generator@^2.0.5",
Expand All @@ -107,6 +107,17 @@
"yeoman-generator-7": "npm:yeoman-generator@^7.0.0",
"yeoman-test": "^10.0.1"
},
"peerDependencies": {
"@yeoman/types": "^1.1.1",
"mem-fs": "^4.0.0"
},
"engines": {
"node": "^18.17.0 || >=20.5.0"
},
"acceptDependencies": {
"@yeoman/adapter": "^2.0.0",
"@yeoman/transform": "^2.1.0"
},
"overrides": {
"yeoman-generator-2": {
"chalk": "^4.1.0",
Expand Down Expand Up @@ -166,15 +177,5 @@
"yeoman-environment": "*"
}
},
"peerDependencies": {
"@yeoman/types": "^1.1.1",
"mem-fs": "^4.0.0"
},
"acceptDependencies": {
"@yeoman/adapter": "^2.0.0",
"@yeoman/transform": "^2.1.0"
},
"engines": {
"node": "^18.17.0 || >=20.5.0"
}
"packageManager": "[email protected]+sha512.a6b2f7906b721bba3d67d4aff083df04dad64c399707841b7acf00f6b133b7ac24255f2652fa22ae3534329dc6180534e98d17432037ff6fd140556e2bb3137e"
}
18 changes: 4 additions & 14 deletions test/generator-features.js
Original file line number Diff line number Diff line change
@@ -1,22 +1,12 @@
import assert from 'node:assert';
import { Module } from 'node:module';
import sinon from 'sinon';
import { after, afterEach, before, beforeEach, describe, esmocha, expect, it } from 'esmocha';
import quibble from 'quibble';
import helpers, { getCreateEnv as getCreateEnvironment } from './helpers.js';
import { greaterThan5 } from './generator-versions.js';
import * as execaModule from 'execa';

if (!Module.register) {
throw new Error('Node greater than v18.19.0 or v20.6.0 is required to test this module.');
}

const commitSharedFsTask = esmocha.fn();
const packageManagerInstallTask = esmocha.fn();
const execa = esmocha.fn();
await quibble.esm('../src/commit.ts', { commitSharedFsTask });
await quibble.esm('../src/package-manager.ts', { packageManagerInstallTask });
await quibble.esm('execa', { ...execaModule, execa });
const { commitSharedFsTask } = await esmocha.mock('../src/commit.js', import('../src/commit.js'));
const { packageManagerInstallTask } = await esmocha.mock('../src/package-manager.js', import('../src/package-manager.js'));
const { execa } = await esmocha.mock('execa', import('execa'));
const { default: BasicEnvironment } = await import('../src/environment-base.js');

for (const generatorVersion of greaterThan5) {
Expand All @@ -28,7 +18,7 @@ for (const generatorVersion of greaterThan5) {
esmocha.resetAllMocks();
});
after(() => {
quibble.reset();
esmocha.reset(true);
});

describe('customCommitTask feature', () => {
Expand Down
14 changes: 3 additions & 11 deletions test/package-manager.js
Original file line number Diff line number Diff line change
@@ -1,18 +1,10 @@
import { Module } from 'node:module';
import path, { dirname } from 'node:path';
import { fileURLToPath } from 'node:url';
import sinon from 'sinon';
import { after, afterEach, beforeEach, describe, esmocha, expect, it } from 'esmocha';
import quibble from 'quibble';

if (!Module.register) {
throw new Error('Node greater than v18.19.0 or v20.6.0 is required to test this module.');
}

const execa = esmocha.fn();
await quibble.esm('execa', { execa });
const whichPackageManager = esmocha.fn();
await quibble.esm('which-package-manager', { whichPackageManager });
const { execa } = await esmocha.mock('execa', import('execa'));
const { whichPackageManager } = await esmocha.mock('which-package-manager', import('which-package-manager'));

const { packageManagerInstallTask } = await import('../src/package-manager.js');

Expand Down Expand Up @@ -43,7 +35,7 @@ describe('environment (package-manager)', () => {
esmocha.resetAllMocks();
});
after(() => {
quibble.reset();
esmocha.reset();
});

describe('#packageManagerInstallTask()', () => {
Expand Down

0 comments on commit 70e04d3

Please sign in to comment.