Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove blue on button, select on iOS 15+ Safari #871

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

studioromeo
Copy link

Hey 👋

On iOS 15+ devices the button text color has changed to blue (via a user-agent style color: -apple-system-blue;).

This is a change from iOS 14- devices which displayed black. While all browsers display buttons slightly differently I felt the blue change was significant enough to warrant a reset as developers might not be expecting this. But I'm also not sure if this is too opinionated for normalize or not, what do you think?

I've put below screenshots of the browsers I have to hand to test on but theres a few key ones missing like IE.

This is my first contribution, I've checked the contributing guidelines and I think I've got everything correct but if theres anything at all let me know 👍

Thanks! 💛

Browser (OS) Before After
Safari (iOS 15) Screenshot 2021-11-08 at 13 24 03 Screenshot 2021-11-08 at 13 24 17
Safari (iOS 13) Screenshot 2021-11-08 at 13 44 05 Screenshot 2021-11-08 at 13 44 21
Chrome 91.0.4472.114 (Android 12) Screenshot 2021-11-08 at 13 52 06 Screenshot 2021-11-08 at 13 52 17
Safari 15.1 (Mac 11.6.1) Screenshot 2021-11-08 at 13 48 22 Screenshot 2021-11-08 at 13 48 29
Chrome 95.0.4638.69 (Mac 11.6.1) Screenshot 2021-11-08 at 13 47 06 Screenshot 2021-11-08 at 13 47 23
Firefox 94.0.1 (Mac 11.6.1) Screenshot 2021-11-08 at 13 49 32 Screenshot 2021-11-08 at 13 49 43

On iOS 15+ devices the button text color has changed to blue
(via color: -apple-system-blue;).

This is a change from iOS 14- devices which displayed black. While all
browsers display buttons slightly differently I felt the blue change was
significant enough to warrant a reset as developers might not be
expecting this.
@garrettw
Copy link

Adding this to my normalize in https://github.com/garrettw/vitals

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants