New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rollback syntax in Testing doc #1723

Open

danielmbarlow wants to merge 1 commit into neo4jrb:11 from danielmbarlow:patch-1

danielmbarlow commented Sep 23, 2024

When using the suggested code from the documuentation:

# For the `neo4j` gem
config.around do |example|
  ActiveGraph::Base.transaction do |tx|
    example.run
    tx.failure
  end
end

We get this error:

NoMethodError:
       undefined method `failure' for an instance of Neo4j::Driver::Internal::InternalTransaction

The syntax is apparently now tx.rollback, however when the transaction has already been rolled back we get this error

     Neo4j::Driver::Exceptions::ClientException:
       Can't rollback, transaction has been rolled back

This pull request changes the documention to recommend:

Usage of the new syntax for rollback
A check to see if the transaction is open before rolling it back


          Update rollback syntax in Testing doc

3a6ea11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet