Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PROCESS_COMPLETIONS_ON_SUBMIT: acquire CQ before submission #50

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

problame
Copy link
Collaborator

@problame problame commented Apr 3, 2024

Before this PR, it could happen that the immediate completion was processed by the poller.
With this PR, it is guaranteed to be processed by the submitter.

TODOs:

  • the comment added in this PR mentions a TODO, should understand whether the poller still gets woken up (=> use tracing_chrome to validate?)
  • do a benchmark run; the nop benchmarks shows a few percent improvement and less variance with a single submitter, which is promising

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant