Skip to content
This repository has been archived by the owner on Jan 10, 2018. It is now read-only.

rename intial probe action from init to probe #256

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

fxck
Copy link

@fxck fxck commented Oct 18, 2016

The first time to probe for an initial state if you did not provide one, the second time when Store is instantiated

https://gitter.im/ngrx/store?at=580662f3759f6d2436c41a32

> The first time to probe for an initial state if you did not provide one, the second time when Store is instantiated

https://gitter.im/ngrx/store?at=580662f3759f6d2436c41a32
@MikeRyanDev
Copy link
Member

Looks like the probing may not be necessary soon. See ReactiveX/rxjs#2050

@JimLynchCodes
Copy link

Hi , sorry dude, but seriously firing"init" twice makes no sense at all and is extremely confusing/ frightening/ worrying for developers (it was for me at least).

Please change one "init" to "probe" and decide later if you want to remove probe (who came up with the name probe anyway lol).

@MarkPieszak
Copy link

Looks like the RxJs issue was just merged the other day (24th), so we should be all set now. Do we need any changes to implement this? @MikeRyan52

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants