Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: update gyp-next to 0.18.3 #55464

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nodejs-github-bot
Copy link
Collaborator

This is an automated update of gyp-next to 0.18.3.

@nodejs-github-bot nodejs-github-bot added gyp Issues and PRs related to the GYP tool and .gyp build files tools Issues and PRs related to the tools directory. labels Oct 20, 2024
@nodejs-github-bot
Copy link
Collaborator Author

Review requested:

  • @nodejs/gyp

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels Oct 20, 2024
Copy link

codecov bot commented Oct 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.42%. Comparing base (61e52c8) to head (2450f38).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #55464   +/-   ##
=======================================
  Coverage   88.41%   88.42%           
=======================================
  Files         653      653           
  Lines      187513   187513           
  Branches    36096    36104    +8     
=======================================
+ Hits       165791   165805   +14     
+ Misses      14961    14950   -11     
+ Partials     6761     6758    -3     

see 37 files with indirect coverage changes

@RedYetiDev
Copy link
Member

Does this even need a CI? It's only doc changes on our end.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. gyp Issues and PRs related to the GYP tool and .gyp build files needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants