Fix #1685 - add adjustable padding between each bar in discreteBar #2136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liquidpele
reviewed
Feb 24, 2018
src/models/discreteBar.js
Outdated
| @@ -216,6 +217,7 @@ nv.models.discreteBar = function() { | |||
|
|
|||
| chart._options = Object.create({}, { | |||
| // simple options, just get/set the necessary values | |||
| barWidth:{get: function(){return barWidth;}, set: function(_){barWidth=_;}}, | |||
There was a problem hiding this comment.
barWidth only makes sense to be between 0 and 1 here right? So it should probably validate that here.
There was a problem hiding this comment.
@liquidpele if it doesn't validate, should I just return the default value or do a console.error?
There was a problem hiding this comment.
I would nv.log it (wrapper around console.log we use) and ignore the passed value.
|
for new options, please also add a description/example in the json object in the bottom of documentation.html |
|
Ok let me do that |
|
Any update? |
|
oh yeah! let me update that on sunday XD |
|
@liquidpele welp, I committed late, but at least it's on a Sunday XD |
|
I wish this were merged, it would be great for my use case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This minimal update will allow dev's to make the bars in discreteBar charts to be narrower