fix(webpack): Remove constraint on Webpack plugin's options for devTool #28508
+9
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current code limits devTool options to hidden(-source-map) and boolean (source-map if true). This is not best coding practice as it limits the extensibility of Nx Webpack plugin. Plus, the plugin's devTool setting overrides custom Webpack config even with webpack-merge implementation.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 618991d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 4 targets
Sent with 💌 from NxCloud. |
4 tasks
|
ATTN: Only the Linux agent failed. No specific error due to code changes could be identified. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Current code limits devTool options to hidden(-source-map) and boolean (source-map if true). This is not best coding practice as it limits the extensibility of Nx Webpack plugin. Plus, the plugin's devTool setting overrides custom Webpack config even with webpack-merge implementation.
Expected Behavior
Nx Webpack plugin and executor should allow all valid options for
devToolto suit diverse use cases for source maps.Related Issue(s)
#28436
Fixes #28436