feat: macos support #63
Draft
+2,031
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc: @Saadnajmi maybe you know what I've missed to make it work with the sidebar? I've been also getting these kind of errors, not sure if this is related to RN macOS or my implementation:
|
Saadnajmi
reviewed
Oct 22, 2024
Comment on lines
+186
to
+195
| #elseif os(macOS) | ||
| let newImage = NSImage(size: size) | ||
| newImage.lockFocus() | ||
| self.draw(in: CGRect(origin: .zero, size: size), | ||
| from: CGRect(origin: .zero, size: self.size), | ||
| operation: .copy, | ||
| fraction: 1.0) | ||
| newImage.unlockFocus() | ||
| return newImage | ||
| #endif |
There was a problem hiding this comment.
Unrelated to the issue you're facing, see a similar change here: microsoft/react-native-macos#2209
lockFocus and that pattern is deprecated in favor of imageWithSize:flipped:drawingHandler:. Similarly, I think UIGraphicsBeginImageContextWithOptions is mostly replaced with UIGraphicsImageRenderer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves #46
Unresolved issue
The view is not sized properly when using sidebar, it's width is always width of the window.