Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable vbe mode listing [fixes #29] #30

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

disable vbe mode listing [fixes #29] #30

wants to merge 1 commit into from

Conversation

stsp
Copy link

@stsp stsp commented Oct 16, 2016

It turns out mode listing hangs when KMS is used.
As vbe modes is not a very important info, it is better to
disable it.

It turns out mode listing hangs when KMS is used.
As vbe modes is not a very important info, it is better to
disable it.
@wfeldt
Copy link
Member

wfeldt commented Oct 25, 2016

Stas, I'm aware of your pr; just haven't had time so far. Will check when I'm back from vacation.

@wfeldt
Copy link
Member

wfeldt commented May 8, 2017

There seems to be some uses of this mode listing left, so I'd rather leave it in, if possible.

I've changed the code now to block all i/o while getting the mode lists. This should prevent issues of libhd crashing the system at the cost of maybe sometimes not getting the mode list.

If that doesn't work as expected (I'm very interested in feedback here) I'll just disable mode listings when kms is active (as it 's done already for reading ddc info).

@stsp
Copy link
Author

stsp commented May 8, 2017

No, there was no whole system crash.
Just locked up hwinfo doing some port IO.
So I really see no reason to disable the IO
unless someone else reported the system
hang.

Also the problem is, I can't reproduce this
any more. I did make clean and rebuilt
without git pull but the problem is not there.
As you can see from the similar report here:
http://bugs.rosalinux.ru/show_bug.cgi?id=7299
the problem depends on the kernel version,
so I guess this was fixed.
I wonder though why you put *.o into
.gitignore - this prevents git clean -f
from working as expected.

@wfeldt
Copy link
Member

wfeldt commented May 12, 2017

I was just working on an issue where it crashed the whole system. So I've taken the real hardware accesses out as far as possible and it seems to work ok so far.

I wonder though why you put *.o into .gitignore - this prevents git clean -f from working as expected.

True enough; I'll clean up .gitignore.

@profi248
Copy link

Tt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants