Return an error when the IP status cannot be updated (#3410)

This status update function was not returning an error when an error occured, and could lead to a crash due returning nil for the IP. Signed-off-by: Todd Short <[email protected]>
operator-framework · Oct 10, 2024 · a63b449 · a63b449
1 parent 619c2eb
commit a63b449
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/pkg/controller/operators/catalog/operator.go b/pkg/controller/operators/catalog/operator.go
@@ -2097,9 +2097,8 @@ func (o *Operator) setInstallPlanInstalledCond(ip *v1alpha1.InstallPlan, reason
 	ip.Status.SetCondition(v1alpha1.ConditionFailed(v1alpha1.InstallPlanInstalled, reason, message, &now))
 	outIP, err := o.client.OperatorsV1alpha1().InstallPlans(ip.GetNamespace()).UpdateStatus(context.TODO(), ip, metav1.UpdateOptions{})
 	if err != nil {
-		logger = logger.WithField("updateError", err.Error())
-		logger.Errorf("error updating InstallPlan status")
-		return nil, nil
+		logger.WithError(err).Error("error updating InstallPlan status")
+		return nil, fmt.Errorf("error updating InstallPlan status: %w", err)
 	}
 	return outIP, nil
 }