Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add /address/:address/cardinals API #3979

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

lifofifoX
Copy link
Collaborator

This would make it easier for apps to rely on the address index for retrieving cardinals UTXOs.

Copy link
Collaborator

@raphjaph raphjaph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far! Just missing a test

src/subcommand/server.rs Outdated Show resolved Hide resolved
tests/json_api.rs Outdated Show resolved Hide resolved
@raphjaph
Copy link
Collaborator

Let me know when this PR is ready for review

@lifofifoX
Copy link
Collaborator Author

@raphjaph Added an additional test to check inscriptions/runes are excluded in cardinals response. Should be ready now!

@lifofifoX
Copy link
Collaborator Author

@raphjaph Added other two endpoints in #4008.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Blocked
Development

Successfully merging this pull request may close these issues.

2 participants