feat(minifier): implement folding charCodeAt string fns
#6475
+75
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Your org has enabled the Graphite merge queue for merging into mainAdd the label “0-merge” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
camc314
force-pushed
the
c/10-10-feat_minifier_implement_folding_charat_string_fns
branch
from
05a79d4
to
273f6f5
Compare
camc314
force-pushed
the
c/10-11-feat_minifier_implement_folding_charcodeat_string_fns
branch
from
5124d0f
to
561ec3d
Compare
CodSpeed Performance ReportMerging #6475 will not alter performanceComparing Summary
|
DonIsaac
reviewed
Oct 12, 2024
| fold_same("x = 'abcde'.charCodeAt(0, ++z)"); // or (++z, 97) | ||
| // START: note the following test cases outputs differ from Google's | ||
| fold("x = 'abcde'.charCodeAt()", "x = 97"); | ||
| fold("x = 'abcde'.charCodeAt(0, ++z)", "x = 97"); |
There was a problem hiding this comment.
This does not appear correct. z++ is missing.
Boshen
force-pushed
the
c/10-10-feat_minifier_implement_folding_charat_string_fns
branch
from
273f6f5
to
096e590
Compare
Base automatically changed from
c/10-10-feat_minifier_implement_folding_charat_string_fns
to
main
October 13, 2024 06:46
Boshen
force-pushed
the
c/10-11-feat_minifier_implement_folding_charcodeat_string_fns
branch
from
561ec3d
to
7d686fc
Compare
7086cmd
reviewed
Oct 13, 2024
Comment on lines
+167
to
+179
| let char_at_index: Option<f64> = match call_expr.arguments.first() { | ||
| Some(Argument::NumericLiteral(numeric_lit)) => Some(numeric_lit.value), | ||
| Some(Argument::UnaryExpression(unary_expr)) | ||
| if unary_expr.operator == UnaryOperator::UnaryNegation => | ||
| { | ||
| let Expression::NumericLiteral(numeric_lit) = &unary_expr.argument else { | ||
| return None; | ||
| }; | ||
| Some(-(numeric_lit.value)) | ||
| } | ||
| None => None, | ||
| _ => return None, | ||
| }; |
There was a problem hiding this comment.
let char_at_index = call_expr.arguments.first().and_then(|idx| ctx.get_number_value(idx))Similar approches, you don't need to handle it manually.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.