Use optional module Scope::Cleanup for trapping exceptions from the finally block #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inally block Currently throwing exception from the finally block show just: Execution of finally() block $code resulted in an exception, which *CAN NOT BE PROPAGATED* due to fundamental limitations of Perl. This patch implements throwing exceptions form the finally block via optional module Scope::Cleanup. When module is not installed then Try::Tiny would show same message as before. When installed, then it cleanup will rethrow exception from finally block back to the caller. There is also a new test which check that finally blocks are always called in same order as before this patch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently throwing exception from the finally block show just:
Execution of finally() block $code resulted in an exception, which
CAN NOT BE PROPAGATED due to fundamental limitations of Perl.
This patch implements throwing exceptions form the finally block via
optional module Scope::Cleanup. When module is not installed then Try::Tiny
would show same message as before. When installed, then it cleanup will
rethrow exception from finally block back to the caller.
There is also a new test which check that finally blocks are always called
in same order as before this patch.