Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes small evaluation bugs related to casts, types, etc #1577

Merged
merged 4 commits into from
Oct 2, 2024
Merged

Fixes small evaluation bugs related to casts, types, etc #1577

merged 4 commits into from
Oct 2, 2024

Conversation

johnedquinn
Copy link
Member

@johnedquinn johnedquinn commented Sep 10, 2024 •
edited
Loading

Description

  • Fixes small evaluation bugs related to casts, types, etc
  • This is in relation to the removal of v0.x APIs from the v1 branch
  • Updated PartiQLResult to return Datum, not PartiQLValue

License Information

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

alancai98
alancai98 reviewed Sep 13, 2024
View reviewed changes
Copy link
Member

@alancai98 alancai98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May also be helpful to give a bit more description on the bugs or have corresponding tests showing the now-fixed behavior.

partiql-spi/src/main/kotlin/org/partiql/value/ion/IonDatum.kt Outdated Show resolved Hide resolved
partiql-planner/src/main/kotlin/org/partiql/planner/internal/transforms/RexConverter.kt Show resolved Hide resolved
partiql-planner/src/main/kotlin/org/partiql/planner/internal/transforms/RexConverter.kt Outdated Show resolved Hide resolved
partiql-eval/src/main/kotlin/org/partiql/eval/internal/operator/rex/CastTable.kt Show resolved Hide resolved
partiql-spi/src/main/java/org/partiql/eval/value/Datum.java Outdated Show resolved Hide resolved
@johnedquinn johnedquinn marked this pull request as draft September 19, 2024 18:26
@johnedquinn johnedquinn marked this pull request as ready for review September 30, 2024 23:02
alancai98
alancai98 approved these changes Oct 2, 2024
View reviewed changes
Copy link
Member

@alancai98 alancai98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pre-approving assuming that small typo is fixed

@RCHowell RCHowell merged commit 433c609 into partiql:v1 Oct 2, 2024
6 checks passed
@RCHowell RCHowell deleted the v1-remove-main-source branch October 2, 2024 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alancai98 alancai98 alancai98 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@johnedquinn @alancai98 @RCHowell