Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move codec implementations to cpp and make codec dependencies private #465

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 20 additions & 6 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,21 @@ option(PISA_ENABLE_CLANG_TIDY "Enable static analysis with clang-tidy" OFF)
option(PISA_CLANG_TIDY_EXECUTABLE "clang-tidy executable path" "clang-tidy")
option(PISA_USE_PIC "Enable Position-Independent code globally" ON)
option(PISA_CI_BUILD "Remove debug information from Debug build" ON)
option(PISA_ENABLE_IPO "Enable Interprocedural Optimization, aka Link Time Optimization (LTO)" OFF)

if(PISA_ENABLE_IPO)
include(CheckIPOSupported)
check_ipo_supported(
RESULT
result
OUTPUT
output)
if(result)
set(CMAKE_INTERPROCEDURAL_OPTIMIZATION TRUE)
else()
message(SEND_ERROR "IPO is not supported: ${output}")
endif()
endif()

if(PISA_USE_PIC)
set(CMAKE_POSITION_INDEPENDENT_CODE ON)
Expand Down Expand Up @@ -111,19 +126,18 @@ target_link_libraries(pisa
fmt::fmt
range-v3
taily
# These should be made private in the future:
FastPFor
streamvbyte
MaskedVByte
simdcomp
QMX
PRIVATE
gumbo::gumbo
warcpp
wapopp
trecpp
Porter2
KrovetzStemmer
QMX
streamvbyte
MaskedVByte
simdcomp
FastPFor
)
target_include_directories(pisa PUBLIC external)

Expand Down
1 change: 1 addition & 0 deletions benchmarks/perftest_interpolative.cpp
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
#include <algorithm>
#include <iostream>
#include <numeric>

#include "spdlog/spdlog.h"

Expand Down
Loading