Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding flag to allow you to list out the opt-ins #318

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

xtreme-steve-elliott
Copy link

Based on feedback from #300 this is PR simply adds the ability to list out available opt-ins using the --list flag to setup.sh. I had it check for the flag before the script runs sudo -K because listing out the options would not require admin and wouldn't actually be installing anything. If it is preferred that it runs after the analytics are turned on / off then I can rearrange some of the code to allow for that.

In my view, the only potential more-complicated-than-it-perhaps-needs-to-be part is the has_param method, which I have to allow for alternate flags (long and compact forms if desired in future), because I was tossing around the idea of allowing a compact flag like -l as an alternative to --list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants