-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change to use vitest. #591
Conversation
Size Change: 0 B Total Size: 3.9 MB ℹ️ View Unchanged
|
Visit the preview URL for this PR (updated for commit 47a2409): https://pixiv-charcoal-web--pr591-naporitan-replace-vi-e18jwjgu.web.app (expires Thu, 18 Jul 2024 05:29:09 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 314b26d3adca98a761c7e4d9922ebb206ff024a0 |
config.resolve.alias = { | ||
...config.resolve.alias, | ||
react: getAbsolutePath('react'), | ||
'react-dom': getAbsolutePath('react-dom'), | ||
'@storybook/react-dom-shim': '@storybook/react-dom-shim', | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yarn storybook:build
fix code
=> Failed to build the preview
SB_BUILDER-WEBPACK5_0002 (WebpackInvocationError): Module not found: Error: Can't resolve 'react-dom/client' in './node_modules/@storybook/react-dom-shim/dist'
.storybook/preview.js
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The .storybook directory is excluded in the tsconfig, but vitest.setup.ts is referenced.
- run: | | ||
yarn lint:eslint | ||
yarn lint:prettier | ||
# v4.0.0 になったら有効化する | ||
# yarn lint:styleilnt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After making changes to yarn.lock, a stylelint error occurred despite not modifying any .tsx files. This issue was not expected to occur since, in version 4.0.0, the files were replaced with .css and development was conducted with stylelint checks without any problems.
parameters: { | ||
storyshots: { | ||
skip: true, | ||
}, | ||
}, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I turned off the generation of jest-styled-components
because the order of the css snapshots changes with each execution. I will turn it back on in v4.
やったこと
動作確認環境
チェックリスト
不要なチェック項目は消して構いません