-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Design Tokens, Add CSS Variables Tests, and Introduce Custom CSS Variables for @charcoal-ui/react
#604
base: v4.0.0
Are you sure you want to change the base?
Conversation
e868021
to
3a1cc80
Compare
Visit the preview URL for this PR (updated for commit d41b3b7): https://pixiv-charcoal-web--pr604-naporitan-replace-to-f16s63p3.web.app (expires Wed, 09 Oct 2024 09:01:01 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 314b26d3adca98a761c7e4d9922ebb206ff024a0 |
Size Change: +234 B (0%) Total Size: 26 MB
ℹ️ View Unchanged
|
…an/replace-token1
@@ -1,3 +1,5 @@ | |||
import './index.css' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
これだとlayeredと切り替えないので、token含めてユーザー側でimportしたほうが良さそうな気がします
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
build 後だと index.css に分離されるのでユーザー側 import にります!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
似たような箇所(variablesなど)にコメントを追記して欲しいです!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
layered と分離されるってことをコメントに残しておくということですか?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
build のために import しており、build 後は js と css に分離されるので js を import すると css が一緒に入ってくることはないことをコメントとして入れる
別件、_variables_light.cssの |
やったこと
@charcoal-ui/react
.動作確認環境
チェックリスト
不要なチェック項目は消して構いません