Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: export removeHalfLeadingCss for migration #626

Closed

Conversation

yue4u
Copy link
Contributor

@yue4u yue4u commented Sep 17, 2024

やったこと

export removeHalfLeadingCss for migration

動作確認環境

チェックリスト

不要なチェック項目は消して構いません

  • 破壊的変更がある場合には、対象のパッケージのメジャーバージョンが上がっていることを確認した
  • 追加したコンポーネントが index.ts から再 export されている
  • README やドキュメントに影響があることを確認した

@@ -16,6 +16,7 @@ export {
useMedia,
} from './helper'
export { defineThemeVariables } from './util'
export { removeHalfLeadingCss } from './utils/typographyCss'
Copy link
Contributor Author

@yue4u yue4u Sep 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When converting theme(o => to raw css using codemod, inlining removeHalfLeadingCss itself will be too verbose.

@mimokmt mimokmt added the minor label Sep 18, 2024
Copy link
Member

@naporin0624 naporin0624 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

snapshot test の update だけしてもらえれば OK かとおもいます!

@yue4u
Copy link
Contributor Author

yue4u commented Oct 3, 2024

snapshot test の update だけしてもらえれば OK かとおもいます!

こちら test -uしてもupdateできなかったでした..

Error: Whoops! Two projects resolved to the same config path: /charcoal/jest.config.mjs:

  Project 1: packages/token-cli
  Project 2: packages/pullrequest-cli

This usually means that your "projects" config includes a directory that doesn't have any configuration recognizable by Jest. Please fix it.

    at ensureNoDuplicateConfigs (/charcoal/node_modules/jest/node_modules/jest-config/build/index.js:395:13)
    at readConfigs (/charcoal/node_modules/jest/node_modules/jest-config/build/index.js:472:5)
    at async runCLI (/charcoal/node_modules/jest/node_modules/@jest/core/build/cli/index.js:132:59)
    at async Object.run (/charcoal/node_modules/jest/node_modules/jest-cli/build/cli/index.js:155:37)

@naporin0624
Copy link
Member

snapshot test の update だけしてもらえれば OK かとおもいます!

こちら test -uしてもupdateできなかったでした..

Error: Whoops! Two projects resolved to the same config path: /charcoal/jest.config.mjs:

  Project 1: packages/token-cli
  Project 2: packages/pullrequest-cli

This usually means that your "projects" config includes a directory that doesn't have any configuration recognizable by Jest. Please fix it.

    at ensureNoDuplicateConfigs (/charcoal/node_modules/jest/node_modules/jest-config/build/index.js:395:13)
    at readConfigs (/charcoal/node_modules/jest/node_modules/jest-config/build/index.js:472:5)
    at async runCLI (/charcoal/node_modules/jest/node_modules/@jest/core/build/cli/index.js:132:59)
    at async Object.run (/charcoal/node_modules/jest/node_modules/jest-cli/build/cli/index.js:155:37)

ちょっとみてみます!

@naporin0624
Copy link
Member

naporin0624 commented Oct 9, 2024

fork されたリポジトリからの PR で編集できなかっため #630 作り直しました 🙏

@yue4u yue4u closed this Oct 10, 2024
@yue4u yue4u deleted the feat/export-removeHalfLeadingCss-for-migration branch October 10, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants