feat: cross-shell completion #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixed cross-shell completion issue:
- Before this change, the completer would rely on the `SHELL` environment
variable provided by the first login shell.
This can be unreliable. For example: Launching another
bash from zsh does not change the `SHELL` environment variable which
was already set to `/bin/zsh`.
- After this change, the completion scripts will explicitly set the
`SHELL` environment variable to whatever shell it supposed to serve
* Replace `systemShell` with `getShellFromEnv` and require the user to
pass `env` explicitly.
zkochan
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed cross-shell completion issue:
SHELLenvironment variable provided by the first login shell. This can be unreliable. For example: Launching bash from zsh does not change theSHELLenvironment variable which was already set to/bin/zsh.SHELLenvironment variable to whatever shell it supposed to serve.Replace
systemShellwithgetShellFromEnvand require the user to passenvexplicitly.