feat:試合表の生成後のエントリーを受け付けないように変更 #551
Open
+58
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying kcmsx with
|
| Latest commit: |
92239f2
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://0f43bbff.kcmsx.pages.dev |
| Branch Preview URL: | https://feat-366-no-entry-after-gene.kcmsx.pages.dev |
speak-mentaiko
requested review from
laminne,
kiharu3112,
tufusa and
Suzune2741
laminne
requested changes
Oct 21, 2024
| @@ -15,6 +19,11 @@ export class EntryService { | |||
| */ | |||
| async enter(teamID: TeamID): Promise<Result.Result<Error, Team>> { | |||
| const teamRes = await this.teamRepository.findByID(teamID); | |||
| const matchRes = await this.preMatch.findAllPreMatch(); | |||
|
|
|||
| if (!Result.isErr(matchRes)) { | |||
There was a problem hiding this comment.
ここはResult.isOkを使うべき
- 試合があるのにエラーが起きない場合もあるはずなので、ここは帰ってきた件数をみるべきだと思う
あとcancelとenterで処理一緒なので共通化して欲しい
There was a problem hiding this comment.
試合が存在する時にエントリー or エントリー解除できないことをテストして欲しいです
tufusa
reviewed
Oct 21, 2024
| const matchRes = await this.preMatch.findAllPreMatch(); | ||
|
|
||
| if (!Result.isErr(matchRes)) { | ||
| return Result.err(new Error('Cannot enter now')); |
There was a problem hiding this comment.
キャンセルなのでCannot cancel entry nowなどにするべきです。また、共通化するならmodify entryなどでもいいでしょう。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #366